[KYUUBI #5035] Spark engine session page display session end time and duration #5038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any screenshots for comparing the changes? |
ok，like this |
cxzl25
approved these changes
Jul 11, 2023
bowenliang123
approved these changes
Jul 11, 2023
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/EngineSessionPage.scala
Outdated
Show resolved
Hide resolved
cxzl25
changed the title
cfmcgrady
approved these changes
Jul 11, 2023
Codecov Report
@@ Coverage Diff @@
## master #5038 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 563 563
Lines 31176 31188 +12
Branches 4070 4072 +2
======================================
- Misses 31176 31188 +12
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| "" | ||
| } else { | ||
| s""" | ||
| |Session end at ${formatDate(sessionStat.endTime)}, |
There was a problem hiding this comment.
Suggested change
| |Session end at ${formatDate(sessionStat.endTime)}, | |
| | ended at ${formatDate(sessionStat.endTime)}, |
|
How about changed to separated lines for connection details and the statistics. |
bowenliang123
approved these changes
Jul 11, 2023
|
Would you like to update the screenshots in the description? And I think this PR is good to go. @lsm1 |
ok，done |
|
Thanks, merged to master. |
link3280
pushed a commit
to link3280/kyuubi
that referenced
this pull request
Jul 23, 2023
…me and duration ### _Why are the changes needed?_ close apache#5035 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate  - [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request Closes apache#5038 from lsm1/features/kyuubi_5035. Closes apache#5035 9ee06f1 [senmiaoliu] fix style c68fd65 [senmiaoliu] fix style 5d3d869 [senmiaoliu] show session end time Authored-by: senmiaoliu <senmiaoliu@trip.com> Signed-off-by: liangbowen <liangbowen@gf.com.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
close #5035
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request