[KYUUBI #6338] Support connecting Kyuubi using Hive JDBC driver 4.0 #6340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fetch.size` conf
github-actions
bot
added
kind:documentation
pan3793
reviewed
Apr 26, 2024
pan3793
reviewed
Apr 26, 2024
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTBinaryFrontendService.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Apr 26, 2024
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTBinaryFrontendService.scala
Outdated
Show resolved
Hide resolved
pan3793
changed the title
kyuubi.server.thrift.resultset.default.fetchsize conf
pan3793
changed the title
pan3793
approved these changes
Apr 26, 2024
wForget
added a commit
that referenced
this pull request
Apr 29, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes #6338 ## Describe Your Solution 🔧 Support `kyuubi.server.thrift.resultset.default.fetchsize` conf to respect `hive.server2.thrift.resultset.default.fetch.size` hive conf. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests KyuubiTBinaryFrontendServiceSuite.test("test kyuubi.server.thrift.resultset.default.fetch.size") --- # Checklist 📝 - [X] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6340 from wForget/KYUUBI-6338. Closes #6338 acd73a1 [wforget] fix 5e64ed3 [wforget] comments 48b8ec6 [wforget] fix style and address comments ca65349 [wforget] [KYUUBI #6338] Support `kyuubi.server.thrift.resultset.default.fetch.size` conf Authored-by: wforget <643348094@qq.com> Signed-off-by: wforget <643348094@qq.com> (cherry picked from commit ef28a61) Signed-off-by: wforget <643348094@qq.com>
|
Thanks, merged to master and branch-1.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #6338
Describe Your Solution 🔧
Support
kyuubi.server.thrift.resultset.default.fetchsizeconf to respecthive.server2.thrift.resultset.default.fetch.sizehive conf.Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
KyuubiTBinaryFrontendServiceSuite.test("test kyuubi.server.thrift.resultset.default.fetch.size")
Checklist 📝
Be nice. Be informative.