-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #6726] Support trino stage progress #6759
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6759 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 684 684
Lines 42282 42288 +6
Branches 5767 5768 +1
======================================
- Misses 42282 42288 +6 ☔ View full report in Codecov by Sentry. |
@taylor12805 Before submitting the pull request, we can use ./dev/reformat to format the code. |
@lsm1 thanks for reminding. I added test case for trino statement progress, however since trino don't have sleep function, I can't mock multiple stages case. Do you have some ideas? |
Adding a sleep function in Trino is not straightforward, so simple unit tests should be sufficient for now. |
🔍 Description
Issue References 🔗
This pull request fixes #6726
Describe Your Solution 🔧
Add trino statement progress
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.