Fix error in resize function in OpenStack driver #1309 #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## trunk #1311 +/- ##
==========================================
- Coverage 85.88% 85.88% -0.01%
==========================================
Files 362 362
Lines 74622 74624 +2
Branches 6827 6828 +1
==========================================
- Hits 64091 64089 -2
- Misses 7774 7776 +2
- Partials 2757 2759 +2
Continue to review full report at Codecov.
|
Kami
reviewed
Jul 12, 2019
| @@ -1588,7 +1588,7 @@ def ex_resize(self, node, size): | |||
|
|
|||
| :rtype: ``bool`` | |||
| """ | |||
| server_params = self._create_args_to_params(node, size=size) | |||
| server_params = {'flavorRef': size.id} | |||
There was a problem hiding this comment.
P.S. Next time it would help if you can link to the corresponding API documentation (e.g. https://developer.openstack.org/api-ref/compute/?expanded=resize-server-resize-action-detail in this case).
Kami
reviewed
Jul 12, 2019
| @@ -1588,7 +1588,7 @@ def ex_resize(self, node, size): | |||
|
|
|||
| :rtype: ``bool`` | |||
| """ | |||
| server_params = self._create_args_to_params(node, size=size) | |||
| server_params = {'flavorRef': size.id} | |||
There was a problem hiding this comment.
For consistency, we should also rename this to ex_resize_node. I will make that change in trunk and leave ex_resize there for backward compatibility reasons.
asfgit
pushed a commit
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error in resize function in OpenStack driver
Description
Fix the error in resize function in OpenStack driver described in issue #1309
Status
Checklist (tick everything that applies)