Support all S3 storage classes #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Kami The changes are ready to review. |
|
Thanks for the contribution and sorry for a late response. I'll review the changes today. |
|
I reviewed the changes - they need some more work (lint is failing, tests is failing, etc.), but besides that they look good to me. I will fix lint and test failure and merge changes into trunk. |
asfgit
pushed a commit
that referenced
this pull request
Jul 31, 2023
|
I fixed lint and failing test and merge your changes into trunk. Thanks again for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support all S3 storage classes
Description
Current version of libcloud supports only "standard" and "reduced_redundancy" storage classes.
AWS S3 add new storage classes during the past two years (https://docs.aws.amazon.com/cli/latest/reference/s3/cp.html).
This PR is to support all S3 storage classes.
Status
Checklist (tick everything that applies)
Closes #1882