Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove executable bit for ssl key fixtures #1960

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

kbrock
Copy link
Contributor

@kbrock kbrock commented Oct 3, 2023

Description

We have a security scanner that noticed that these fixtures are chmod x+a Since these are data files, best to make them non-executable

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

We have a security scanner that noticed that these fixtures are chmod x+a
Since these are data files, best to make them non-executable
@codecov-commenter
Copy link

Codecov Report

Merging #1960 (d42da57) into trunk (966ba6d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk    #1960   +/-   ##
=======================================
  Coverage   83.19%   83.19%           
=======================================
  Files         353      353           
  Lines       81387    81387           
  Branches     8586     8586           
=======================================
  Hits        67707    67707           
  Misses      10874    10874           
  Partials     2806     2806           

Copy link
Member

@Kami Kami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@Kami Kami merged commit 9b15938 into apache:trunk Oct 4, 2023
18 checks passed
@kbrock kbrock deleted the non-exec-fixtures branch October 5, 2023 16:49
@kbrock
Copy link
Contributor Author

kbrock commented Oct 5, 2023

Thank you @Kami for supporting us all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants