-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LIBCLOUD-614] multiple bugfixes and improvements to GCE #360
Commits on Sep 16, 2014
-
GCE: healthcheck: add description param to ex_create_healthcheck(); t…
…argetpool: multiple bugfixes Fix apache#1: targetpool = driver.ex_get_targetpool('tpname') targetpool.add_node(node) node.destroy() # targetpool still contains the node targetpool = driver.ex_get_targetpool('tpname') # targetpool.nodes contains node uri string (in addition to possible other node objects) # as produced by _to_targetpool because the node is in the pool but is destroyed targetpool.remove_node(node) # raises an exception, removes the node nevertheless. Expected behavior: remove the node, return true Fix apache#2: targetpool.add(node) targetpool.add(node) # targetpool.nodes contains 2 copies of node # actual targetpool resource on the GCE side doesn't contain 2 copies Expected behavior: no duplicates in targetpool.nodes, the node list matches GCE side Fix/Improvement apache#3: Allow specifying nodes by fully-qualified node uri in add_node and remove_node. if tp.nodes: tp.remove_node(tp.nodes[0]) # fails if the node in the list doesn't exist exoected behavior: should be able to remove any node from the list GCE allows adding non-existent nodes to the targetpool and doesn't automatically remove nodes from the pool if you delete them. libcloud should support doing the same.
Configuration menu - View commit details
-
Copy full SHA for 7911570 - Browse repository at this point
Copy the full SHA 7911570View commit details -
GCE: fix ex_targetpool_add_healthcheck and ex_targetpool_remove_healt…
…hcheck. The requests were malformed and thus did nothing.
Configuration menu - View commit details
-
Copy full SHA for d84a823 - Browse repository at this point
Copy the full SHA d84a823View commit details -
GCE: add a parameter to ex_create_address to promote specific ephemer…
…al addresses to static ones.
Configuration menu - View commit details
-
Copy full SHA for 5beec36 - Browse repository at this point
Copy the full SHA 5beec36View commit details -
GCE: add description parameter to ex_create_forwarding_rule, improve …
…tests; fix documentation and test fixtures for health checks
Configuration menu - View commit details
-
Copy full SHA for 49de63c - Browse repository at this point
Copy the full SHA 49de63cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b457589 - Browse repository at this point
Copy the full SHA b457589View commit details -
GCE: ex_create_firewall: allow creation og firewalls with sourceRange…
…s = [], preserve behavior for sourceRanges = None, preserve default value. GCE documentation states that firewall allows traffic if it matches either sourceRanges or sourceTags values. Thus, sourceRanges = [] is a valid parameter value. Although it would be better to simply set ["0.0.0.0/0"] as the default, for minimal API breakage, None value is still supported.
Configuration menu - View commit details
-
Copy full SHA for bcafb9b - Browse repository at this point
Copy the full SHA bcafb9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 784427f - Browse repository at this point
Copy the full SHA 784427fView commit details
Commits on Sep 19, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 39aecd1 - Browse repository at this point
Copy the full SHA 39aecd1View commit details