Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] [Entrance]Support to remove the limit added by default in sql according to the configured Creator #1573

Closed
2 tasks done
peacewong opened this issue Feb 28, 2022 · 0 comments

Comments

@peacewong
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Problem Description

Now, when submitting sql/hql by default, the limit of 5000 will be added. However, for many non-interactive analysis scenarios, the limit limit should not be added by default, otherwise, the user task data will be wrong.

现在默认提交sql/hql都会加上limit 5000的限制,但是对于很多非交互式分析的场景来说,默认不应该加入limit限制,不然会造成用户任务数据有误。只有对特定场景加上5000,比如Scriptis页面使用,为了更好的性能。

select * from users 
## Limit will be added after entrance
select * from users limit 5000

Description

Adding parameters can configure only a specific Creator to add a limit limit(增加参数可以配置只有特定的Creator才加上limit限制)

Use case

No response

solutions

Add the following parameters, only the Creator configured in it has a limit limit(增加以下参数,只有配置在里面的Creator才有limit限制)
val SQL_LIMIT_CREATOR = CommonVars("linkis.sql.limit.creator", "IDE,Visualis")

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@peacewong peacewong added the enhancement New feature or request label Feb 28, 2022
@peacewong peacewong changed the title [Feature] [Entrance]Support to remove the limit limit added by default in sql according to the configured Creator [Feature] [Entrance]Support to remove the limit added by default in sql according to the configured Creator Mar 5, 2022
peacewong added a commit to WeDataSphere/linkis that referenced this issue Mar 5, 2022
peacewong added a commit that referenced this issue Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant