-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add doris engine to linkis #5053
Conversation
Thank you, can you use json as code to pass? Parameters that do not apply to runtime Map |
@@ -75,6 +75,9 @@ public class LabelCommonConfig { | |||
public static final CommonVars<String> NEBULA_ENGINE_VERSION = | |||
CommonVars.apply("wds.linkis.nebula.engine.version", "3.0.0"); | |||
|
|||
public static final CommonVars<String> DORIS_ENGINE_VERSION = | |||
CommonVars.apply("wds.linkis.doris.engine.version", "1.2.6"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove wds prefix
public static final CommonVars<Integer> ENGINE_CONCURRENT_LIMIT = | ||
CommonVars.apply("linkis.engineconn.concurrent.limit", 100); | ||
|
||
public static final CommonVars<Integer> ENGINE_DEFAULT_LIMIT = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should 'linkis.engineconn.doris' prefix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks for reviewing the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this need optimize,thanks
|
||
<configuration status="error" monitorInterval="30"> | ||
<appenders> | ||
<Console name="Console" target="SYSTEM_OUT"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should use RollingFile
} | ||
logger.info("Doris engine begins to run code:\n {}", realCode); | ||
|
||
checkRequiredParameter(code); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should use realCode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks for reviewing the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
[Feature] Add doris engine to linkis
Support cvs, json, parquet, orc format file import doris
Submit sample
{
"executionContent": {"code": "{"linkis.ec.doris.stream.load.file.path":"/Users/chengjie/Downloads/doris/test.csv","linkis.ec.doris.database":"demo","linkis.ec.doris.table":"example_tbl"}", "runType": "doris"},
"params": {
"variable": {},
"configuration": {
"runtime": {
"linkis.ec.doris.host":"192.168.201.54",
"linkis.ec.doris.2pc.enabled":true,
"linkis.ec.doris.http.port":8030
}
}
},
"source": {"scriptPath": "file:///mnt/bdp/hadoop/1.sql"},
"labels": {
"engineType": "doris-1.2.6",
"userCreator": "linkis-IDE"
}
}
Execution result