Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Apache Logging Services reusable workflows #419

Open
wants to merge 15 commits into
base: trunk
Choose a base branch
from

Conversation

ppkarwasz
Copy link
Contributor

This PR switches Flume to use the reusable workflows from apache/logging-parent.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

This PR switches Flume to use the reusable workflows from
apache/logging-parent.
@grobmeier grobmeier requested a review from rgoers March 25, 2024 10:17
@rgoers
Copy link
Member

rgoers commented Oct 3, 2024

I apologize. I never saw this. I have been in the middle of splitting the repo into multiple projects and then got pulled away. I believe the changes you made should apply though so I can give it a try.

@ppkarwasz
Copy link
Contributor Author

The changes might be a little bit out of date. This must have been based on logging-parent version 10.0.0 or so.

@ppkarwasz
Copy link
Contributor Author

That is probably the best I can do for now.

The build is failing, but the failures are logged to the Develocity server. You can analyze it at https://ge.apache.org/scans?search.rootProjectNames=Apache%20Flume%20Project&search.timeZoneId=Europe%2FWarsaw#

@ppkarwasz
Copy link
Contributor Author

BTW: I bumped the JDK used by the build (but not the JRE requirement) to 11. Many Maven plugins don't work any more on JDK 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants