Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove liquibase-log4j2 module #1193

Merged
merged 5 commits into from
Feb 2, 2023
Merged

remove liquibase-log4j2 module #1193

merged 5 commits into from
Feb 2, 2023

Conversation

StevenMassaro
Copy link
Contributor

Remove the liquibase-log4j2 maven module.

The existing module does not work with any recent version of Liquibase, and per previous discussions (see #503) it would be best to remove the code from the log4j2 codebase. Liquibase intends to release and maintain our own implementation of the necessary log4j2 extension.

@StevenMassaro StevenMassaro marked this pull request as ready for review January 9, 2023 18:06
@ppkarwasz
Copy link
Contributor

@StevenMassaro,

That's great news: log4j-liquibase have been lacking contributors for years. Can you post a message on the dev@logging.apache.org mailing list, so that we can coordinate the migration of users to the official Liquibase plugin?

@StevenMassaro
Copy link
Contributor Author

@StevenMassaro,

That's great news: log4j-liquibase have been lacking contributors for years. Can you post a message on the dev@logging.apache.org mailing list, so that we can coordinate the migration of users to the official Liquibase plugin?

@ppkarwasz , Liquibase has not released their extension for log4j yet. Would that be a prerequisite for removing this code? I was hoping to remove this code since it caused me some confusion on a recent project I was working on, until I realized that it was out of date.

@jvz jvz added this to the 2.20.0 milestone Jan 13, 2023
@jvz
Copy link
Member

jvz commented Jan 13, 2023

We can do it whenever if it's already outdated. The next release even.

@StevenMassaro
Copy link
Contributor Author

We can do it whenever if it's already outdated. The next release even.

Excellent! Do you need anything else from me?

@jvz jvz added the plugins Affects the plugin system label Jan 14, 2023
@jvz
Copy link
Member

jvz commented Jan 14, 2023

Rebase/merge from current please? :)

# Conflicts:
#	log4j-liquibase/pom.xml
#	log4j-liquibase/src/site/site.xml
@StevenMassaro
Copy link
Contributor Author

Rebase/merge from current please? :)

Done!

# Conflicts:
#	log4j-liquibase/pom.xml
#	pom.xml
#	src/site/markdown/log4j-liquibase.md
#	src/site/site.xml
@StevenMassaro
Copy link
Contributor Author

@jvz Is there anything you need from me for this PR before it can be merged?

@jvz
Copy link
Member

jvz commented Feb 1, 2023

May be helpful to add a changelog entry for this. We just adopted a simpler system for filing them: https://github.com/apache/logging-log4j2/blob/release-2.x/CHANGELOG.adoc

You can file a GitHub Issue to go with this, too, providing additional details. Otherwise, you can simply link to this PR for the changelog entry.

@StevenMassaro
Copy link
Contributor Author

@jvz Just added the changelog entry. I saw that the build failed, though to my untrained eye the failures look unrelated to my changes. Let me know if I'm reading that wrong.

@jvz
Copy link
Member

jvz commented Feb 2, 2023

Yeah that looks irrelevant, don't worry.

@jvz jvz merged commit b1e1643 into apache:release-2.x Feb 2, 2023
@jvz
Copy link
Member

jvz commented Feb 2, 2023

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins Affects the plugin system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants