-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove liquibase-log4j2 module #1193
Conversation
That's great news: |
@ppkarwasz , Liquibase has not released their extension for log4j yet. Would that be a prerequisite for removing this code? I was hoping to remove this code since it caused me some confusion on a recent project I was working on, until I realized that it was out of date. |
We can do it whenever if it's already outdated. The next release even. |
Excellent! Do you need anything else from me? |
Rebase/merge from current please? :) |
# Conflicts: # log4j-liquibase/pom.xml # log4j-liquibase/src/site/site.xml
Done! |
# Conflicts: # log4j-liquibase/pom.xml # pom.xml # src/site/markdown/log4j-liquibase.md # src/site/site.xml
@jvz Is there anything you need from me for this PR before it can be merged? |
May be helpful to add a changelog entry for this. We just adopted a simpler system for filing them: https://github.com/apache/logging-log4j2/blob/release-2.x/CHANGELOG.adoc You can file a GitHub Issue to go with this, too, providing additional details. Otherwise, you can simply link to this PR for the changelog entry. |
@jvz Just added the changelog entry. I saw that the build failed, though to my untrained eye the failures look unrelated to my changes. Let me know if I'm reading that wrong. |
Yeah that looks irrelevant, don't worry. |
Thanks for the PR! |
Remove the liquibase-log4j2 maven module.
The existing module does not work with any recent version of Liquibase, and per previous discussions (see #503) it would be best to remove the code from the log4j2 codebase. Liquibase intends to release and maintain our own implementation of the necessary log4j2 extension.