Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade LMAX Disruptor to version 4.0.0 #1937

Closed
wants to merge 4 commits into from

Conversation

tomerarazy
Copy link
Contributor

No description provided.

@vy
Copy link
Member

vy commented Nov 1, 2023

@tomerarazy, I don't think this will work. See #1829 and LOG4J2-3595. We would appreciate it if you can submit a PR fixing the issue via the way described in LOG4J2-3595.

@tomerarazy
Copy link
Contributor Author

@tomerarazy, I don't think this will work. See #1829 and LOG4J2-3595. We would appreciate it if you can submit a PR fixing the issue via the way described in LOG4J2-3595.

If I understand the issue is backward compatibility with older Java versions, I don't mind taking a shot at this but I'm not familiar with the log4j (other than as a user) so I don't even know where to start looking on how different Java versions affect which code we're loading, can you please provide some pointers to where I can start looking?

@ppkarwasz
Copy link
Contributor

I would prefer to use the trick I described in #1856.

In Disruptor 4.x two things changed:

  • EventHandler has new default methods that come from its previous sub-interfaces,
  • some sub-interfaces of EventHandler disappeared.

We can easily work with this, so that:

  • our code compiles with Disruptor 3.x,
  • users can use both Disruptor 3.x and Disruptor 4.x at runtime.

The details are in #1856.

@jvz
Copy link
Member

jvz commented Nov 11, 2023

I'm going to go ahead and apply this idea to main since that has a baseline requirement of Java 11 already.

@jvz
Copy link
Member

jvz commented Nov 11, 2023

Straightforward approach in main: 9dcb10b

@ppkarwasz ppkarwasz self-assigned this Dec 19, 2023
Fixes apache#1829

Signed-off-by: tomerarazy <tomerarazy@gmail.com>
@ppkarwasz ppkarwasz force-pushed the lmax-disruptor-4-0-0 branch 3 times, most recently from 23000c6 to 4169bb0 Compare December 19, 2023 20:06
An additional test run will ensure `log4j-core` works with Disruptor
4.x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants