-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade LMAX Disruptor to version 4.0.0 #1937
Conversation
@tomerarazy, I don't think this will work. See #1829 and LOG4J2-3595. We would appreciate it if you can submit a PR fixing the issue via the way described in LOG4J2-3595. |
If I understand the issue is backward compatibility with older Java versions, I don't mind taking a shot at this but I'm not familiar with the log4j (other than as a user) so I don't even know where to start looking on how different Java versions affect which code we're loading, can you please provide some pointers to where I can start looking? |
I would prefer to use the trick I described in #1856. In Disruptor 4.x two things changed:
We can easily work with this, so that:
The details are in #1856. |
I'm going to go ahead and apply this idea to main since that has a baseline requirement of Java 11 already. |
Straightforward approach in main: 9dcb10b |
Fixes apache#1829 Signed-off-by: tomerarazy <tomerarazy@gmail.com>
23000c6
to
4169bb0
Compare
An additional test run will ensure `log4j-core` works with Disruptor 4.x.
4169bb0
to
55dd02b
Compare
No description provided.