Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port log4j-mongodb4 changes from 2.x #2164

Merged
merged 18 commits into from
Jan 5, 2024
Merged

Conversation

ppkarwasz
Copy link
Contributor

We port the missing fixes from the 2.x branch to main.

For the log4j-mongodb4 module these are:

@ppkarwasz
Copy link
Contributor Author

BTW: this regression in main is probably fixed: #1439

@ppkarwasz ppkarwasz self-assigned this Jan 4, 2024
Piotr P. Karwasz and others added 18 commits January 5, 2024 15:41
`LogManager.getGlobal().getLevel()` is not a good fallback for the case
when all JUL logger levels are null, since its level is usually null.
Workaround a Coursier/Ivy dependency resolution bug that affects
`log4j-slf4j-impl` and `log4j-mongodb3`.

This bug also affects popular sites like MvnRepository (cf.
[`log4j-mongodb3:2.22.0`](https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-mongodb3/2.22.0)).

Closes apache#2065
This PR adds to the `log4j-script` module the missing changes from the `2.x` branch.

Since the module was created by moving classes from `log4j-core` the
comparison between branches must be done file by file.
in order to wait for the handlers to be registered in the root logger
They are in the `provider` classpath of the Surefire process.
@ppkarwasz ppkarwasz merged commit 0fa8ba5 into apache:main Jan 5, 2024
6 checks passed
@ppkarwasz ppkarwasz deleted the sync-mongodb4 branch January 5, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants