Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix forgotten threadName field in RingBufferLogEvent#clear() (#2234) #2239

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix forgotten threadName field in RingBufferLogEvent#clear() (#2234) #2239

merged 1 commit into from
Jan 24, 2024

Conversation

vy
Copy link
Member

@vy vy commented Jan 24, 2024

No description provided.

@vy vy added bug Incorrect, unexpected, or unintended behavior of existing code async Affects asynchronous loggers or appenders labels Jan 24, 2024
@vy vy added this to the 2.23.0 milestone Jan 24, 2024
@vy vy requested a review from ppkarwasz January 24, 2024 10:12
@vy vy self-assigned this Jan 24, 2024
ppkarwasz
ppkarwasz approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Can you port it to main too, so that we don't have regressions?

@vy vy merged commit 6cb09b2 into 2.x Jan 24, 2024
7 checks passed
@vy vy deleted the 2.x-RingBufferLogEvent-clear branch January 24, 2024 10:35
@vy
Copy link
Member Author

vy commented Jan 24, 2024

@ppkarwasz, will do.

vy added a commit that referenced this pull request Jan 24, 2024
@vy
Fix forgotten threadName field in RingBufferLogEvent#clear() (#2234…
0c5c21d 
…, #2239)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppkarwasz ppkarwasz ppkarwasz approved these changes

Assignees

@vy vy

Labels
async Affects asynchronous loggers or appenders bug Incorrect, unexpected, or unintended behavior of existing code
Projects
None yet
Milestone
2.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vy @ppkarwasz