Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StatusLogger to correctly read log4j2.StatusLogger.properties #2354

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Fix StatusLogger to correctly read log4j2.StatusLogger.properties #2354

merged 3 commits into from
Mar 6, 2024

Conversation

vy
Copy link
Member

@vy vy commented Mar 5, 2024

As reported here by @carterkozak, StatusLogger logic to read the log4j2.StatusLogger.properties resource is broken. This PR addresses that.

@vy vy added bug Incorrect, unexpected, or unintended behavior of existing code api Affects the public API labels Mar 5, 2024
@vy vy added this to the 2.23.1 milestone Mar 5, 2024
@vy vy requested a review from carterkozak March 5, 2024 21:04
@vy vy self-assigned this Mar 5, 2024
@vy vy mentioned this pull request Mar 5, 2024
Merged
carterkozak
carterkozak approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @vy!

@vy
Copy link
Member Author

vy commented Mar 5, 2024 •
edited
Loading

Looks great, thank you @vy!

@carterkozak, thanks for the prompt review! 🚀
Will merge the PR when CI checks pass.

@vy vy merged commit a4a8e99 into 2.x Mar 6, 2024
9 checks passed
@vy vy deleted the 2.x-StatusLogger-properties branch March 6, 2024 08:34
@venusdrogon venusdrogon mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterkozak carterkozak carterkozak approved these changes

Assignees

@vy vy

Labels
api Affects the public API bug Incorrect, unexpected, or unintended behavior of existing code
Projects
None yet
Milestone
2.23.1
Development

Successfully merging this pull request may close these issues.
2 participants
@vy @carterkozak