Add logging to PropertiesUtil and fix Duration parser
#2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vy
requested changes
Mar 28, 2024
log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java
Outdated
Show resolved
Hide resolved
log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java
Outdated
Show resolved
Hide resolved
log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java
Outdated
Show resolved
Hide resolved
log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java
Outdated
Show resolved
Hide resolved
log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java
Show resolved
Hide resolved
log4j-api/src/main/java/org/apache/logging/log4j/util/SystemPropertiesPropertySource.java
Show resolved
Hide resolved
vy
approved these changes
Apr 1, 2024
ppkarwasz
force-pushed
the
fix/1963_add_logging_to_properties_util
branch
from
377cca4
to
202cd35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiting from the
StatusLoggerenhancements in #2273, we add logging statement inPropertiesUtil.We also add tests for the
getDurationPropertymethod and fix its behavior.Part of #2290.
Closes #1963