Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom context data in ctx lookup #2846

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

ppkarwasz
Copy link
Contributor

@ppkarwasz ppkarwasz commented Aug 16, 2024

This backports (from the 2.25.x branch), the support for custom context data providers in the ctx lookup.
The feature was first introduced in #2438.

Closes #2331.

Copy link
Member

@vy vy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested minor changes, overall LGTM.

ppkarwasz added a commit that referenced this pull request Aug 26, 2024
This backports (from the `2.25.x` branch), the support
 for custom context data providers in the `ctx` lookup.
The feature was first introduced in #2438.

Includes #2846 review.
@ppkarwasz ppkarwasz force-pushed the fix/2.x/multiple-ctx-lookup-sources branch from c475dbf to 9c3e24a Compare August 26, 2024 13:26
@ppkarwasz ppkarwasz merged commit 9c3e24a into 2.x Aug 26, 2024
5 of 7 checks passed
@ppkarwasz ppkarwasz deleted the fix/2.x/multiple-ctx-lookup-sources branch August 26, 2024 13:26
ppkarwasz added a commit that referenced this pull request Sep 1, 2024
This backports (from the `2.25.x` branch), the support
 for custom context data providers in the `ctx` lookup.
The feature was first introduced in #2438.

Includes #2846 review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContextDataInjector ignores custom ContextDataProvider
2 participants