Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(1.2-api): migrate to junit5 #3067

Draft
wants to merge 4 commits into
base: 2.x
Choose a base branch
from
Draft

refactor(1.2-api): migrate to junit5 #3067

wants to merge 4 commits into from

Conversation

hulkoba
Copy link
Contributor

@hulkoba hulkoba commented Oct 7, 2024 •
edited
Loading

39 of 39 Files...

Progress

There in still one test failure, I have to investigate

 Failures: 
[ERROR]   Log4j1ConfigurationFactoryTest>AbstractLog4j1ConfigurationTest.testMultipleFilters:497 expected: <4> but was: <1>

Checklist

  • Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
  • ./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
  • Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
  • Tests for the changes are provided
  • Commits are signed (optional, but highly recommended)

@ppkarwasz ppkarwasz added the tests Pull requests or issues related to tests label Oct 7, 2024
@hulkoba hulkoba force-pushed the refactor-1.2-api-junit5 branch 3 times, most recently from d316a5c to 252f28f Compare October 11, 2024 10:24
@github-actions GitHub Actions
Copy link

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 ❌ Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 ❌ Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 ❌ Build Scan PUBLISHED
Generated by gradle/develocity-actions

@ppkarwasz
Copy link
Contributor

@hulkoba,

In #3039 I removed some ancient and disabled tests from log4j-1.2-api. To prevent some useless work, make sure you base your PR on a recent 2.x commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests Pull requests or issues related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hulkoba @ppkarwasz