Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump jetty-util from 8.2.0.v20160908 to 9.4.46.v20220331 #883

Merged
merged 3 commits into from
May 28, 2022
Merged

Bump jetty-util from 8.2.0.v20160908 to 9.4.46.v20220331 #883

merged 3 commits into from
May 28, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 23, 2022 •
edited
Loading

Bumps jetty-util from 8.2.0.v20160908 to 11.0.9.

Release notes

Sourced from jetty-util's releases.

11.0.9

Special Thanks to the following Eclipse Jetty community members

Changelog

  • #7748 - Allow overriding of url-pattern mapping in ServletContextHandler to allow for regex or uri-template matching
  • #7677 - jetty-maven-plugin - maven internal dependencies included on webapp classloader
  • #7657 - Remove unused test imports in jetty-nosql
  • #7655 - Remove unused imports in jetty-gcloud
  • #7633 - Make osgi build work with snapshot jsp jars
  • #7625 - HTTP/3 error against www.google.com
  • #7617 - Logback-access RequestLog not working
  • #7615 - HttpServletResponse.encodeURL not working for URLs starting with ../
  • #7613 - Configurations.add(Configuration) results in UnsupportedOperationException
  • #7605 - Honor parameters order when parsing query and form parameters
  • #7575 - Misleading docs for HttpClientTransportDynamic
  • #7574 - Turn off peer cerificate verification for quic-server by default (@​sunng87)
  • #7573 - WebSockets - "Unsupported PathParam Type: java.lang.Integer"
  • #7567 - Gzip compression not working for multipart/form-data when added to the allowed list using addIncludedMimeTypes.
  • #7548 - Interrupt flag is not always cleared in between requests
  • #7547 - Fix typo in java doc (@​kaiyuezhou)
  • #7545 - Named arguments do not work in jetty-openid.xml
  • #7544 - Add option to allow well-known directories to be listed.
  • #7524 - Missing package in JmxConfiguration
  • #7523 - Typo in AnnotationConfiguration
  • #7517 - Some ArrayTrie methods throw StackOverflowError when cointaining a very large entry
  • #7514 - Adding InheritedListeners to already-started components can cause IllegalStateException
  • #7513 - Getter/setter type mismatch for mbean attribute file in class org.eclipse.jetty.deploy.PropertiesConfigurationManager
  • #7496 - Transient 400: Bad Request responses
  • #7430 - Run WebSocket Autobahn test for all Jetty, Javax and Core APIs
  • #7414 - QoSFilter.setMaxRequests throws NullPointerException
  • #7344 - Incompatible with jacoco due to shutdown race condition
  • #7182 - jetty.sh start process should remove jetty_state whenever deleting the pid (@​ianrifkin)
  • #6879 - Remove jminix (not maintained) module as hawtio provide same features
  • #6282 - SecuredRedirectHandler should probably redirect with 301 (@​dellgreen)
  • #6017 - Property overriding does not work
  • #5965 - Option --write-module-graph produces wrong .dot file
  • #5681 - Unrecognized jetty-home/start.jar command line option not reported clearly

Dependencies

  • #7498 - Bump asciidoctor-maven-plugin to 2.2.2
  • #7695 - Bump awaitility to 4.2.0

... (truncated)

Commits
  • 243a48a Updating to version 11.0.9
  • cc0eb6e Merge remote-tracking branch 'origin/jetty-10.0.x' into jetty-11.0.x
  • c99b704 Bump grpc-core from 1.45.0 to 1.45.1 (#7804)
  • 6b25c27 Bump jolokia-war from 1.3.3 to 1.7.1 (#6907)
  • cfcd67f Bump jna-jpms from 5.10.0 to 5.11.0 (#7793)
  • 1ce2d33 Bump mariadb-java-client from 3.0.3 to 3.0.4 (#7789)
  • 325f2a2 Bump jna-jpms from 5.10.0 to 5.11.0 (#7788)
  • 2335b66 Bump mariadb-java-client from 3.0.3 to 3.0.4 (#7787)
  • 93d607d Bump jackson-databind from 2.13.2 to 2.13.2.1 (#7785)
  • 0255f4f Merge remote-tracking branch 'origin/jetty-10.0.x' into jetty-11.0.x
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @ppkarwasz.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Related to third party dependency updates or migrations label May 23, 2022
@jvz
Copy link
Member

jvz commented May 28, 2022

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/org.eclipse.jetty-jetty-util-11.0.9 branch from c0271dd to 8284daf Compare May 28, 2022 02:23
@dependabot
Bump jetty-util from 8.2.0.v20160908 to 11.0.9
bc3cbc6 
Bumps [jetty-util](https://github.com/eclipse/jetty.project) from 8.2.0.v20160908 to 11.0.9.
- [Release notes](https://github.com/eclipse/jetty.project/releases)
- [Commits](jetty/jetty.project@jetty-8.2.0.v20160908...jetty-11.0.9)

---
updated-dependencies:
- dependency-name: org.eclipse.jetty:jetty-util
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/org.eclipse.jetty-jetty-util-11.0.9 branch from 8284daf to bc3cbc6 Compare May 28, 2022 03:07
@ppkarwasz
Change the version to 9.4
060b9c6 
Jetty 9.x is the last version that does not use SLF4J natively: cf.
[Jetty 9 documentation](https://www.eclipse.org/jetty/documentation/jetty-9/index.html#configuring-logging)
vs
[Jetty 10
documentation](https://www.eclipse.org/jetty/documentation/jetty-10/operations-guide/index.html#og-logging)

Given the EOL announcement jetty/jetty.project#7958, this is the last
upgrade we need to perform.
@ppkarwasz
Copy link
Contributor

Jetty 9.x is the last version that does not use SLF4J natively: cf. Jetty 9 documentation vs Jetty 10 documentation.

Given the EOL announcement jetty/jetty.project#7958, the upgrade to 9.4 would be the last major upgrade we need to perform.

@ppkarwasz
Copy link
Contributor

@dependabot merge

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 28, 2022

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@ppkarwasz
Remove managed dependency
7c94989 
Beyond `log4j-appserver`, `wiremock` also uses Jetty, but an older
version.
@dependabot dependabot bot merged commit ed8185d into release-2.x May 28, 2022
@dependabot dependabot bot deleted the dependabot/maven/org.eclipse.jetty-jetty-util-11.0.9 branch May 28, 2022 12:12
@garydgregory
Copy link
Member

Something feels wrong because Jetty 11 requires Java > 8 right?

@ppkarwasz ppkarwasz changed the title Bump jetty-util from 8.2.0.v20160908 to 11.0.9 Bump jetty-util from 8.2.0.v20160908 to 9.4.46.v20220331 May 28, 2022
@ppkarwasz
Copy link
Contributor

@garydgregory,

Yes, Jetty 10 and 11 requires Java 11. Moreover they use SLF4J 2.0 (sic!) for their internal logging.

So the only version of jetty-util we are interested in is 9.4, which contains the custom logging API used by previous versions of Jetty. I actually modified this PR to upgrade to 9.4.46 instead of 11.0.9.

This was referenced May 30, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Related to third party dependency updates or migrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvz @ppkarwasz @garydgregory