Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-15099 Add null checks to IndexSizeTrigger #2244

Open
wants to merge 1 commit into
base: branch_8x
Choose a base branch
from

Conversation

megancarey
Copy link
Contributor

…its are enqueued

Description

Want to avoid noisy NPE on core info variables since we already log.warn on line 330.

Solution

Minor fix: add null checks on the core info variables, as we've seen on ZK restarts that these are unavailable.

Tests

Ran IndexSizeTrigger test locally and it succeeded. Didn't add tests for this.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the master branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Ref Guide (for Solr changes only).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant