Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MASSEMBLY-1013] Remove custom SAR UnArchiver #175

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

slawekjaranowski
Copy link
Member

It is implemented by newer plexus-archiver


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MASSEMBLY-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MASSEMBLY-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

It is implemented by newer plexus-archiver
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is fine though I'm missing context on it. The linked bug doesn't explain this specifically. What is "SAR"?

@slawekjaranowski
Copy link
Member Author

SAR is a type of archive, but never mind what it is - it is implemented in https://github.com/codehaus-plexus/plexus-archiver/tree/master/src/main/java/org/codehaus/plexus/archiver/sar
So I remove as duplicated code.

@slawekjaranowski slawekjaranowski merged commit cd88812 into master Dec 17, 2023
45 checks passed
@slawekjaranowski slawekjaranowski deleted the MASSEMBLY-1013 branch December 17, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants