[MCOMPILER-381] - Refactor incremental detection

[jorsol]

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace MCOMPILER-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[slawekjaranowski]

@khmarbaise looks like you reported issue which this PR try to fix ... can you look?

[slawekjaranowski]

@olamy - any more remarks on it, I would like to merge

[jorsol]

Hi @olamy, is there any other feedback?

[jorsol]

Well, I think this should be ready to be merged if there is no other comment.

BTW, looking at the open issues, this should also fix MCOMPILER-333 so it can be linked to this and declare it fixed for 3.12.0

[olamy]

Well, I think this should be ready to be merged if there is no other comment.

BTW, looking at the open issues, this should also fix MCOMPILER-333 so it can be linked to this and declare it fixed for 3.12.0

it's usually better to have a PR per change, especially in case of non-related changes.
But as you already hijacked this PR #186 here, it would be good to have this in the PR title and commits for history.
And obviously, update https://issues.apache.org/jira/browse/MCOMPILER-333

[jorsol]

Well, I think this should be ready to be merged if there is no other comment.
BTW, looking at the open issues, this should also fix MCOMPILER-333 so it can be linked to this and declare it fixed for 3.12.0

it's usually better to have a PR per change, especially in case of non-related changes. But as you already hijacked this PR #186 here, it would be good to have this in the PR title and commits for history. And obviously, update https://issues.apache.org/jira/browse/MCOMPILER-333

Sure, will create a new PR for that change. the fix is simpler than the one from #186.

Reverted the change here and included it on #214

[olamy]

@jorsol thanks for creating another PR with the other change!

[olamy]

mvn spotless:apply should help here ;)

[jorsol]

mvn spotless:apply should help here ;)

Done! 😅