[DOXIA-711] Introduce SinkWrapper and according SinkWrapperFactory #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a BufferingSinkProxyWrapper which buffers all calls on the underlying sink until it is flushed.
kwin
force-pushed
the
feature/sink-wrapper
branch
from
39b177c to
c7ad2c7
Compare
kwin
commented
Dec 23, 2023
doxia-core/src/main/java/org/apache/maven/doxia/parser/SinkWrapper.java
Outdated
Show resolved
Hide resolved
Extend Javadoc of PipelineSink and RandomAccessSink to reference the more effective SinkWrapper approach
kwin
commented
Dec 23, 2023
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/PipelineSink.java
Outdated
Show resolved
Hide resolved
kwin
commented
Dec 23, 2023
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/RandomAccessSink.java
Outdated
Show resolved
Hide resolved
michael-o
requested changes
Dec 23, 2023
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/BufferingSinkProxyFactory.java
Outdated
Show resolved
Hide resolved
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/BufferingSinkProxyFactory.java
Show resolved
Hide resolved
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/BufferingSinkProxyFactory.java
Outdated
Show resolved
Hide resolved
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/PipelineSink.java
Outdated
Show resolved
Hide resolved
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/RandomAccessSink.java
Outdated
Show resolved
Hide resolved
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/SinkWrapperFactoryComparator.java
Outdated
Show resolved
Hide resolved
michael-o
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a BufferingSinkProxyWrapper which buffers all calls on the underlying sink until it is flushed.