Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MJAVADOC-716] Fix stale files detection failing because of the newline #144

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Jun 1, 2022

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MJAVADOC-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@michael-o
Copy link
Member

michael-o commented Oct 29, 2023

@gnodet Is this one complete to be included in the next release?

@gnodet
Copy link
Contributor Author

gnodet commented Oct 30, 2023

I think so.

@michael-o
Copy link
Member

I think so.

Can you rebase and merge?

@gnodet gnodet force-pushed the MJAVADOC-716 branch 2 times, most recently from 7ff4946 to 16a6fdf Compare October 30, 2023 20:30
@asfgit asfgit merged commit 45a8d29 into apache:master Nov 3, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants