[JXR-172] Upgrade Parent to 37, project cleanup #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- upgrade parent to 37 - remove configuration which override parent pom items - use the same version of plugins in project and IT tests - improvement assertions in IT tests
michael-o
reviewed
Jul 26, 2022
| </pluginRepositories> | ||
| </profile> | ||
| </profiles> | ||
| <activeProfiles> | ||
| <activeProfile>it-repo</activeProfile> | ||
| </activeProfiles> | ||
| </settings> |
There was a problem hiding this comment.
Why do we need this settings file at all? I ran the tests without and they success. There is no settings file in MPIR.
There was a problem hiding this comment.
Needed for m-invoker-p https://maven.apache.org/plugins/maven-invoker-plugin/examples/fast-use.html
There was a problem hiding this comment.
Interesting, in other plugins I haven't seen it. Did you check the time difference actually?
There was a problem hiding this comment.
MPIR also has such settings: https://github.com/apache/maven-project-info-reports-plugin/blob/master/src/it/settings.xml
There was a problem hiding this comment.
There was a problem hiding this comment.
One thing is time consumed be test and second is how many items are download from remote repository.
without settings.xml
[INFO] --- maven-invoker-plugin:3.3.0:run (integration-test) @ maven-jxr-plugin ---
[INFO] Building: simple-project/pom.xml
[INFO] run post-build script verify.groovy
[INFO] simple-project/pom.xml ........................... SUCCESS (23.1 s)
[INFO] Building: JXR-100_parameterlink/pom.xml
[INFO] run post-build script verify.groovy
[INFO] JXR-100_parameterlink/pom.xml .................... SUCCESS (3.5 s)
[INFO] Building: aggregate/pom.xml
[INFO] run post-build script verify.groovy
[INFO] aggregate/pom.xml ................................ SUCCESS (10.3 s)
[INFO] Building: mixed-plugin-report/pom.xml
[INFO] run post-build script verify.groovy
[INFO] mixed-plugin-report/pom.xml ...................... SUCCESS (13.0 s)
[INFO] Building: JXR-135_innerclasses/pom.xml
[INFO] JXR-135_innerclasses/pom.xml ..................... SUCCESS (1.8 s)
[INFO] Building: JXR-143_nofork/pom.xml
[INFO] run post-build script verify.groovy
[INFO] JXR-143_nofork/pom.xml ........................... SUCCESS (5.5 s)
[INFO] Building: new-site-config/pom.xml
[INFO] run post-build script verify.groovy
[INFO] new-site-config/pom.xml .......................... SUCCESS (5.3 s)
[INFO] -------------------------------------------------
[INFO] Build Summary:
[INFO] Passed: 7, Failed: 0, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Maven JXR Parent 3.2.1-SNAPSHOT:
[INFO]
[INFO] Maven JXR Parent ................................... SUCCESS [ 2.545 s]
[INFO] Maven JXR .......................................... SUCCESS [ 3.217 s]
[INFO] Maven JXR Plugin ................................... SUCCESS [01:10 min]
[INFO] ------------------------------------------------------------------------
with settings.xml
[INFO] --- maven-invoker-plugin:3.3.0:run (integration-test) @ maven-jxr-plugin ---
[INFO] Building: simple-project/pom.xml
[INFO] run post-build script verify.groovy
[INFO] simple-project/pom.xml ........................... SUCCESS (5.9 s)
[INFO] Building: JXR-100_parameterlink/pom.xml
[INFO] run post-build script verify.groovy
[INFO] JXR-100_parameterlink/pom.xml .................... SUCCESS (1.8 s)
[INFO] Building: aggregate/pom.xml
[INFO] run post-build script verify.groovy
[INFO] aggregate/pom.xml ................................ SUCCESS (6.1 s)
[INFO] Building: mixed-plugin-report/pom.xml
[INFO] run post-build script verify.groovy
[INFO] mixed-plugin-report/pom.xml ...................... SUCCESS (12.2 s)
[INFO] Building: JXR-135_innerclasses/pom.xml
[INFO] JXR-135_innerclasses/pom.xml ..................... SUCCESS (1.6 s)
[INFO] Building: JXR-143_nofork/pom.xml
[INFO] run post-build script verify.groovy
[INFO] JXR-143_nofork/pom.xml ........................... SUCCESS (3.5 s)
[INFO] Building: new-site-config/pom.xml
[INFO] run post-build script verify.groovy
[INFO] new-site-config/pom.xml .......................... SUCCESS (4.2 s)
[INFO] -------------------------------------------------
[INFO] Build Summary:
[INFO] Passed: 7, Failed: 0, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Maven JXR Parent 3.2.1-SNAPSHOT:
[INFO]
[INFO] Maven JXR Parent ................................... SUCCESS [ 2.145 s]
[INFO] Maven JXR .......................................... SUCCESS [ 2.473 s]
[INFO] Maven JXR Plugin ................................... SUCCESS [ 42.544 s]
[INFO] ------------------------------------------------------------------------
There was a problem hiding this comment.
I will add do MIRP 😄
There was a problem hiding this comment.
hehe parent magic 😄
so MPIR use settings.xml in IT tests
There was a problem hiding this comment.
Oh man, I was blind for years. Can we apply this here as well?
Not used in IT test, project use version from parent 37 -> 3.3.0 |
michael-o
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[JXR-XXX] - Fixes bug in ApproximateQuantiles,where you replace
JXR-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.