Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full terminal width in CLI with Maven 4 #889

Closed
wants to merge 1 commit into from

Conversation

KasNotten
Copy link
Contributor

I am trying to solve the following issue: #870

As far as I can determine this code (Also contains some test code which can be removed later) should work for using the full terminal width in maven-mvnd, comparing it with the code in the maven repository for using the full terminal width in maven 4.

However, the terminal width is always -1.

Can anyone shed some light on as to why this is happening? Maybe @ppalaga or @gnodet ?

@gnodet
Copy link
Contributor

gnodet commented Oct 15, 2023

Your PR is wrong. Jansi cannot be used as there's no terminal. I'll try to investigate.

@gnodet
Copy link
Contributor

gnodet commented Oct 16, 2023

The terminal width is sent by the client.
A proposed fix is available at #891

@gnodet gnodet closed this Oct 16, 2023
@gnodet gnodet added this to the 1.0-m8 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants