Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make our lives simpler: mvnd is Java17 #956

Closed
wants to merge 1 commit into from

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Apr 20, 2024

To ease our lives, mvnd is Java17. m40 is already Java17, and now m39 requires it as well.

This is okay constraint, as it someone must have Java8 running Maven 3.9.x, Maven 3.9.x + smart builder is still there and works on Java8.

Fixes #954

To ease our lives, mvnd is Java17. m40 is already Java17,
and now m39 requires it as well.

This is okay constraint, as it someone must have Java8
running Maven 3.9.x, Maven 3.9.x + smart builder is still
there and works on Java8.

Fixes apache#954
@cstamas cstamas requested review from gnodet and ppalaga April 20, 2024 17:36
@cstamas cstamas self-assigned this Apr 20, 2024
@gnodet
Copy link
Contributor

gnodet commented Apr 20, 2024

To ease our lives, mvnd is Java17. m40 is already Java17, and now m39 requires it as well.

This is okay constraint, as it someone must have Java8 running Maven 3.9.x, Maven 3.9.x + smart builder is still there and works on Java8.

Fixes #954

I disagree, it's there and it's working. I don't think anyone had any problem with it since its introduction. If we do split again between 3.9.x and 4.x support, then we can surely drop some stuff from the 4.x branch.
Also, this PR seems to remove the java fallback which is used to make mvnd work on platforms which are not supported by the native builds.

@cstamas
Copy link
Member Author

cstamas commented Apr 20, 2024

But, locally am not building native, so how does mvnd work for me then?

@gnodet
Copy link
Contributor

gnodet commented Apr 20, 2024

But, locally am not building native, so how does mvnd work for me then?

The native binary is preferred when available. Then java-mvnd is used to run mvnd in JVM mode and JDK >= 11. The java-fallback is used in JVM mode when JDK < 11 and basically falls back to plain maven. The goal is to be able to always use mvnd instead of maven. You don't have to care, it will just work whatever your environment is. What your PR propose, is, of course, a simplification of the code, but it will limit the usage of mvnd to a smaller set of supported combinations of platforms + JDK.

@cstamas
Copy link
Member Author

cstamas commented Apr 23, 2024

Agreed, closing this one out

@cstamas cstamas closed this Apr 23, 2024
@cstamas cstamas deleted the java-17 branch April 23, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make mvnd Java17
2 participants