Skip to content

Commit

Permalink
Revert "Bump maven-shared-resources from 2 to 4 (#31)"
Browse files Browse the repository at this point in the history
This reverts commit be57b24.

As maven-shared-resources 3+ has this commit:
apache/maven-shared-resources@5fbc3eb

That according to doco
https://checkstyle.sourceforge.io/config_filefilters.html#BeforeExecutionExclusionFileFilter
is "since 7.2", while maven-checkstyle-plugin:3.0.0 uses checkstyle 6.18

Moreover, maven-shared-resources 4+ has this commit:
apache/maven-shared-resources@fbef6f6
that requires checkstyle 8.42+

Currently there is no release of maven-checkstyle-plugin that uses checkstyle 8.42+
hence reverting this commit.
  • Loading branch information
cstamas committed Oct 20, 2021
1 parent 5386f54 commit c468598
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion maven-extensions/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ under the License.
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-shared-resources</artifactId>
<version>4</version>
<version>2</version>
</dependency>
</dependencies>
</plugin>
Expand Down
2 changes: 1 addition & 1 deletion maven-plugins/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ under the License.
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-shared-resources</artifactId>
<version>4</version>
<version>2</version>
</dependency>
</dependencies>
</plugin>
Expand Down
2 changes: 1 addition & 1 deletion maven-shared-components/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ under the License.
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-shared-resources</artifactId>
<version>4</version>
<version>2</version>
</dependency>
</dependencies>
</plugin>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1027,7 +1027,7 @@ under the License.
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-shared-resources</artifactId>
<version>4</version>
<version>2</version>
</dependency>
</dependencies>
</plugin>
Expand Down

0 comments on commit c468598

Please sign in to comment.