[MPOM-270] Fix enforcer plugin #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforcer as is causes that downstream in case of update POM must completely redefine plugin, thus, loosing all the benefits of parent POM pluginMgmt. Move plugin definition to pluginMgmt instead to fully define it and it's dependines in plugin section. Keep execution in plugin section. Update to latest enforcer as well. ------ See for example apache/maven-resolver#129
slachiewicz
approved these changes
Oct 14, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforcer as is causes that downstream in case of update
POM must completely redefine plugin, thus, loosing all
the benefits of parent POM pluginMgmt.
Move plugin definition to pluginMgmt instead to fully
define it and it's dependines in plugin section. Keep
execution in plugin section.
Update to latest enforcer as well.
See for example apache/maven-resolver#129