[MPOM-298] Cleanup dependencyLocationsEnabled from MPIR configuration #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
reviewed
Feb 25, 2022
| @@ -1209,9 +1209,6 @@ under the License. | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-project-info-reports-plugin</artifactId> | |||
| <configuration> | |||
| <dependencyLocationsEnabled>false</dependencyLocationsEnabled><!-- waiting for MPIR-267 --> | |||
| </configuration> | |||
There was a problem hiding this comment.
The issue has been autoclosed, Is this the right thing to do?
There was a problem hiding this comment.
Yes was removed in https://issues.apache.org/jira/browse/MPIR-367
Wrong comments
There was a problem hiding this comment.
not wrong comment: the real issue is MPIR-267
but I discover that the problem was "solved" by removing the feature in MPIR-367
then yes, no need to keep the configuration, thanks for noticing this
michael-o
approved these changes
Feb 25, 2022
slachiewicz
approved these changes
Feb 25, 2022
|
can you explain what it is about, please? |
hboutemy
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.