[MPOM-313] execute checkstyle in early phase of the build #55
Conversation
| @@ -1170,6 +1170,7 @@ under the License. | |||
| <executions> | |||
| <execution> | |||
| <id>checkstyle-check</id> | |||
| <phase>validate</phase> | |||
There was a problem hiding this comment.
This also means that autogenerated code won't be checked?
There was a problem hiding this comment.
correct so maybe generate-sources phase.
but do we really care about checkstyle generated code?
in this case we need to ask the plugin authors to change the style of the generated code?
There was a problem hiding this comment.
it's just frustrating to run a long build and get a missing space at the end...
just forget a space in surefire-its it means you run everything for at least 1h (with a beefy laptop) and the build failure 😩
There was a problem hiding this comment.
correct so maybe generate-sources phase. but do we really care about checkstyle generated code? in this case we need to ask the plugin authors to change the style of the generated code?
Сorrect, we don't care, I guess.
There was a problem hiding this comment.
it's just frustrating to run a long build and get a missing space at the end... just forget a space in surefire-its it means you run everything for at least 1h (with a beefy laptop) and the build failure 😩
Agree
|
Simple change - can save some of time during development. |
not from me 🤣 |
slawekjaranowski
force-pushed
the
checkstyle-validate-phase
branch
from
31eff1a
to
8f6463d
Compare
slawekjaranowski
changed the title
No description provided.