Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPMD-369] Make integration tests robust against system encoding #122

Merged
merged 2 commits into from
Apr 6, 2023
Merged

[MPMD-369] Make integration tests robust against system encoding #122

merged 2 commits into from
Apr 6, 2023

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Apr 5, 2023 •
edited
Loading

There are more instances to be fixed but I think these two are the major offenders that break the integration tests.

@elharo elharo requested a review from michael-o April 5, 2023 17:54
michael-o
michael-o approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah, the dreaded file reader.

@elharo elharo merged commit 2530d84 into master Apr 6, 2023
@elharo elharo deleted the cherrypick branch April 6, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elharo @michael-o