-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPMD-395] Build doesn't fail for invalid CPD format #150
Conversation
Will try to review in the next couple of days. |
src/main/java/org/apache/maven/plugins/pmd/exec/CpdReportConsumer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/pmd/exec/CpdExecutor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/pmd/exec/PmdErrorMessageReporter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/pmd/exec/CpdExecutor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/pmd/exec/CpdReportConsumer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/pmd/exec/CpdReportConsumer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/pmd/exec/PmdErrorMessageReporter.java
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
src/main/java/org/apache/maven/plugins/pmd/exec/CpdReportConsumer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/pmd/exec/PmdErrorMessageReporter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/pmd/exec/CpdReportConsumer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/pmd/exec/CpdReportConsumer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/pmd/exec/CpdReportConsumer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/pmd/exec/PmdErrorMessageReporter.java
Outdated
Show resolved
Hide resolved
@adangel thanks for the rework, will review again. |
src/main/java/org/apache/maven/plugins/pmd/exec/CpdReportConsumer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/pmd/exec/CpdReportConsumer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All clean for me, good to merge. Thank you for your patience! I can already see that the code can be a bit simplified with Doxia 2.0.0, but that is a separate topic. Please go ahead and complete this change. I will take care of the next release.
Thank you as well!
Just for this fix I don't think a new release is needed immediately. It's sufficient, if this lands in the next release whenever it happens. |
True, swallowing exceptions is not good and I need to bump to Maven 3.6.3 anyway. |
https://issues.apache.org/jira/browse/MPMD-395
Refs #144 (comment)
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MPMD-XXX] - Subject of the JIRA Ticket
,where you replace
MPMD-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.