Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPMD-395] Build doesn't fail for invalid CPD format #150

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

adangel
Copy link
Member

@adangel adangel commented May 10, 2024

https://issues.apache.org/jira/browse/MPMD-395

Refs #144 (comment)

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MPMD-XXX] - Subject of the JIRA Ticket,
    where you replace MPMD-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@michael-o
Copy link
Member

Will try to review in the next couple of days.

@michael-o michael-o self-requested a review May 10, 2024 15:06
@michael-o

This comment was marked as resolved.

@adangel adangel requested a review from michael-o June 6, 2024 08:22
@michael-o
Copy link
Member

@adangel thanks for the rework, will review again.

@michael-o michael-o self-requested a review June 6, 2024 17:09
michael-o pushed a commit to adangel/maven-pmd-plugin that referenced this pull request Jun 6, 2024
@michael-o michael-o self-requested a review June 6, 2024 18:22
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All clean for me, good to merge. Thank you for your patience! I can already see that the code can be a bit simplified with Doxia 2.0.0, but that is a separate topic. Please go ahead and complete this change. I will take care of the next release.

@adangel
Copy link
Member Author

adangel commented Jun 7, 2024

Thank you as well!

I will take care of the next release.

Just for this fix I don't think a new release is needed immediately. It's sufficient, if this lands in the next release whenever it happens.

@adangel adangel merged commit 76f7e11 into apache:master Jun 7, 2024
20 checks passed
@michael-o
Copy link
Member

Thank you as well!

I will take care of the next release.

Just for this fix I don't think a new release is needed immediately. It's sufficient, if this lands in the next release whenever it happens.

True, swallowing exceptions is not good and I need to bump to Maven 3.6.3 anyway.

@adangel adangel deleted the MPMD-395 branch June 11, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants