Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPMD-391] Log what developers care about and not what they don't #156

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

michael-o
Copy link
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MPMD-XXX] - Subject of the JIRA Ticket,
    where you replace MPMD-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

michael-o added a commit that referenced this pull request Jul 7, 2024
michael-o added a commit that referenced this pull request Jul 7, 2024
* Don't log PMD/CPD version for report mojos since report output will
  contain it anyway.
* Log PMD/CPD failures and warnings at WARNING level to draw attention.
* Don't log PMD/CPD version for check mojos by default.
* Integrate PMD/CPD version into failure message only.

This closes #156
michael-o added a commit that referenced this pull request Jul 7, 2024
* Don't log PMD/CPD version for report mojos since report output will
  contain it anyway.
* Log PMD/CPD failures and warnings at WARNING level to draw attention.
* Don't log PMD/CPD version for check mojos by default.
* Integrate PMD/CPD version into failure message only.

This closes #156
@michael-o michael-o marked this pull request as ready for review July 7, 2024 22:19
@michael-o michael-o requested review from adangel and elharo July 7, 2024 22:20
@michael-o
Copy link
Member Author

Note: Some issues mentioned in the JIRA ticket are out of control of this plugin therefore there are out of scope here.

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

michael-o added a commit that referenced this pull request Jul 9, 2024
* Don't log PMD/CPD version for report mojos since report output will
  contain it anyway.
* Log PMD/CPD failures and warnings at WARNING level to draw attention.
* Don't log PMD/CPD version for check mojos by default.
* Integrate PMD/CPD version into failure message only.

This closes #156
* Don't log PMD/CPD version for report mojos since report output will
  contain it anyway.
* Log PMD/CPD failures and warnings at WARNING level to draw attention.
* Don't log PMD/CPD version for check mojos by default.
* Integrate PMD/CPD version into failure message only.

This closes #156
@michael-o michael-o closed this in 277a725 Jul 9, 2024
@michael-o michael-o merged commit 277a725 into master Jul 9, 2024
51 checks passed
@michael-o michael-o deleted the MPMD-391 branch July 9, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants