[MPMD-412] Remove unused code and otherwise cleanup tests #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
changed the title
|
Test passes locally. Not sure why it's failing in CI: Error: org.apache.maven.plugins.pmd.CpdViolationCheckMojoTest.testException -- Time elapsed: 0.126 s <<< FAILURE! |
|
Also, all tests do appear to be passing on some of the builds, just not all of them. |
|
Possibly only failing on Windows? Need a windows system to test on |
elharo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleanup revealed bugs in tests including in testInvalidTargetJdk and PmdViolationCheckMojoTest where the tests were incorrectly configured so the wrong exceptions were thrown. That is, the tests were in fact failing but this was hidden by an overly broad catch clause.