[MRESOLVER-365] Upgrade dependencies #294
Conversation
Update, and produce a bundle that simply needs to be unzipped, drop all that site stuff that is hard and error prone to maintain.
As it is now misleading
|
Done, #296 |
| </dependency> | ||
| <dependency> | ||
| <groupId>javax.inject</groupId> | ||
| <artifactId>javax.inject</artifactId> | ||
| <optional>true</optional> | ||
| <scope>provided</scope> | ||
| </dependency> |
There was a problem hiding this comment.
This I don't fully understand, what if used outside of Maven, will this still work?
There was a problem hiding this comment.
No, just like any maven plugin (w/ these scopes) will not resolve all the needed dependencies outside of Maven. IMHO these artifacts are meant for one thing: to be dropped into ${maven.home}/lib/ext and nothing more. More cautiously one could say "to be dropped into existing (and working) resolver classpath", but then again scope is right, as "working classpath" of resolver HAS this artifact.
There was a problem hiding this comment.
One may consider these as "manually installed plugins for resolver" as that's what both do (hazelcast and redisson), they add themselves and their (not yet present) dependencies, like hazelcast and redisson w/ transitive hull.
There was a problem hiding this comment.
But what is the pain then? You create a project with Resolver and Hazelcast named lock, all deps are there, not related to Maven usage. They end up in CP anyway, no?
There was a problem hiding this comment.
Yes, resolver brings in needed stuff, hence "provided"
| @@ -39,21 +39,23 @@ | |||
| <dependencies> | |||
| <dependency> | |||
| <groupId>org.apache.maven.resolver</groupId> | |||
| <artifactId>maven-resolver-api</artifactId> | |||
| <artifactId>maven-resolver-named-locks</artifactId> | |||
| <scope>provided</scope> | |||
There was a problem hiding this comment.
This chang will make dependency:analyze complain. You should reatin retain it at provided scope.
There was a problem hiding this comment.
No it will not, try it out
There was a problem hiding this comment.
(but i ignore test scope in that output)
https://issues.apache.org/jira/browse/MRESOLVER-365