[MRESOLVER-437][MRESOLVER-438] Do not force set Expect-Continue setting #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But allow users to override defailt (that comes from transport being in use). --- https://issues.apache.org/jira/browse/MRESOLVER-437
cstamas
changed the title
rmannibucau
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
LGTM with a small side note (not blocking)
side note: think default http version should be 1.1 (until we enhance our protocol to use it somehow) cause http 2 has several issues (a lot of servers and some which can impact clients). Boost is not that huge once keep alive is on for us so let's not abuse it in our defaults?
PS: thanks for the hyphen typo fix ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But allow users to override default (that comes from transport being in use). Also, ignore this setting on Java versions below 20. Finally, align class names for jdk transport as they were inconsistent.
https://issues.apache.org/jira/browse/MRESOLVER-437
https://issues.apache.org/jira/browse/MRESOLVER-438