Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRESOLVER-321] Make collection and visiting interruptable #380

Merged
merged 6 commits into from
Nov 27, 2023

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Nov 27, 2023

Currently the two collector implementations are not interrupt-able, do not sense interruption directly, only by some side-effect like IO. Moreover, the BF new collector may enter a "busy loop" as we seen (it was due bug, but nothing prevents us to have more bugs). Make main loop in both collector detect thread interruption and use global (per-collection) Args to carry state of the, interruption effectively the whole ST or MT collection.

Same stands for dependency visitor: it may also enter busy loop in case of cycles, hence, it should be made also interrupt-able. Visitor OTOH should not reset the interrupted flag, it should just stop when it is set, and let the flag be handled at higher level (for example in collector).


https://issues.apache.org/jira/browse/MRESOLVER-321

Currently the two collection are not interruptable,
does not sense interruption directly, only by some
side-effect like IO. Moreover, the BF new collector
may enter a "busy loop" as we seen, true, it was
due bug, but nothing prevents us to have more bugs.

Make main loop in both collector detect thread interruption
and use global (per-collection) Args to carry state of
the, interruption effectively the whole ST or MT
collection.

---

https://issues.apache.org/jira/browse/MRESOLVER-321
flag, just interrupt the work, and let
that be handled somewhere else (ie. collector)
@cstamas cstamas changed the title [MRESOLVER-321] Make collection interruptable [MRESOLVER-321] Make collection and visiting interruptable Nov 27, 2023
@cstamas cstamas merged commit 4801d20 into apache:master Nov 27, 2023
4 checks passed
@cstamas cstamas deleted the MRESOLVER-321 branch November 27, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants