[1.9.x] [MRESOLVER-572] Export internal packages in OSGi metadata as x-internal #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase |
HannesWell
force-pushed
the
maven-resolver-1.9.x-572
branch
from
49f313f
to
4a39991
Compare
HannesWell
force-pushed
the
maven-resolver-1.9.x-572
branch
from
353b3c9
to
ddcf0ad
Compare
HannesWell
force-pushed
the
maven-resolver-1.9.x-572
branch
from
ddcf0ad
to
cf895a4
Compare
|
@gnodet can we proceed with this one? Thanks in advance. |
gnodet
changed the title
This makes maven-resolver-supplier usable as bundle in an OSGi runtime. At the moment the bundle cannot resolve because the internal.impl packages it uses and imports in its OSGi metadata are not exported by maven-resolver-impl. Simply exporting internal packages fixes that and, although it is discouraged to use internal/impl packages, gives consumers that can accept no API-compatibility guarantees the ability to access these packages. Adding the directive 'x-internal' is a convention that, at least when using Eclipse PDE, shows a corresponding warning at call-sides. Fixes https://issues.apache.org/jira/browse/MRESOLVER-572
HannesWell
force-pushed
the
maven-resolver-1.9.x-572
branch
from
84cee96
to
1fe422f
Compare
|
Are snapshots deployed for the |
I've deployed one manually. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes maven-resolver-supplier usable as bundle in an OSGi runtime.
At the moment the bundle cannot resolve because the
internal.implpackages it uses and imports in its OSGi metadata are not exported bymaven-resolver-impl.Just exporting internal packages fixes that and, although it is discouraged to use internal/impl packages, gives consumers that can
accept no API-compatibility guarantees the ability to access these packages.
Adding the directive
x-internalis a convention that, at least when using Eclipse PDE, shows a corresponding warning at call-sides.Fixes https://issues.apache.org/jira/browse/MRESOLVER-572
This PR is currently a draft since it contains as first commit the build unification of #509 and is built on top of that.