Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCM-939] Towards JUnit4 ... DRAFT !! #150

Closed
wants to merge 1 commit into from
Closed

[SCM-939] Towards JUnit4 ... DRAFT !! #150

wants to merge 1 commit into from

Conversation

nielsbasjes
Copy link
Contributor

First steps to make use of JUnit 4 so the assume methods actually work as expected.

Some tests pass, several do not.

@michael-o
Copy link
Member

@cstamas WDYT?

@michael-o
Copy link
Member

@nielsbasjes I did a few updates...

@nielsbasjes
Copy link
Contributor Author

@nielsbasjes I did a few updates...

Yes of course. Please change/copy/do what you think is best with my partial contribution.
Feel free to take it over completely because I do not have enough understanding of several key components to finish it.

@michael-o
Copy link
Member

@nielsbasjes I did a few updates...

Yes of course. Please change/copy/do what you think is best with my partial contribution. Feel free to take it over completely because I do not have enough understanding of several key components to finish it.

For me, this looks decent now, but I want to make a few more checks. @kwin Do you want to review?

michael-o pushed a commit to nielsbasjes/maven-scm that referenced this pull request Apr 8, 2024
@nielsbasjes @michael-o
[SCM-939] Assume SCM is present
bdf7ac4 
Co-authored-by: Michael Osipov <michaelo@apache.org>

This closes apache#150
michael-o pushed a commit to nielsbasjes/maven-scm that referenced this pull request Apr 8, 2024
@nielsbasjes @michael-o
[SCM-939] Assume SCM is present
838331e 
Co-authored-by: Michael Osipov <michaelo@apache.org>

This closes apache#150
@michael-o michael-o self-requested a review April 8, 2024 21:07
@michael-o michael-o marked this pull request as ready for review April 8, 2024 21:07
@nielsbasjes @michael-o
[SCM-939] Assume SCM is present
c46e07a 
Co-authored-by: Michael Osipov <michaelo@apache.org>

This closes apache#150
@michael-o michael-o requested a review from kwin April 9, 2024 07:02
michael-o
michael-o approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with that now and aligned the naming with Maven Release for consistency reasons.

@michael-o michael-o closed this in 95817d6 Apr 11, 2024
@nielsbasjes
Copy link
Contributor Author

Thanks @michael-o !

@nielsbasjes nielsbasjes deleted the SCM-939-AssumeSCM branch April 11, 2024 13:21
@michael-o
Copy link
Member

Thanks @michael-o !

No issue, appreciated. There might be better solutions for JUnit 4, but this is fine for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

@kwin kwin Awaiting requested review from kwin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsbasjes @michael-o