Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6847] Use diamond operator #184

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

timtebeek
Copy link
Contributor

Hi! Found MNG-6847 on the backlog (closed), but that had only been applied to apache/maven#315 itself, not the additional 36 projects that could still use those changes. Figured open this one as a first one to ask if you'd appreciate any more.

These PRs are trivial for me to create, but I would not want to cause any review burden. That's why I'm only starting with one, and not creating more unless I get a positive response here.

Here's a full list of projects that could still use these changes.

 38 apache/maven-scm
 20 apache/maven-wagon
 19 "apache/maven-shared-utils"
 12 "apache/maven-resolver-ant-tasks"
 11 "apache/maven-integration-testing"
 11 "apache/maven-doxia-sitetools"
 11 "apache/maven-apache-resources"
  9 apache/maven-shared-io
  9 apache/maven-resolver
  9 apache/maven-ear-plugin
  7 "apache/maven-changelog-plugin"
  7 "apache/maven-assembly-plugin"
  7 apache/maven
  6 apache/maven-ant-tasks
  5 apache/maven-site-plugin
  5 "apache/maven-dependency-plugin"
  4 "apache/maven-plugin-tools"
  4 apache/maven-ejb-plugin
  4 "apache/maven-doxia-linkcheck"
  4 "apache/maven-doxia-book-renderer"
  3 "apache/maven-shade-plugin"
  3 apache/maven-mvnd
  2 "apache/maven-project-info-reports-plugin"
  2 "apache/maven-install-plugin"
  2 apache/maven-dist-tool
  1 "apache/maven-stage-plugin"
  1 "apache/maven-remote-resources-plugin"
  1 "apache/maven-project-utils"
  1 apache/maven-pmd-plugin
  1 apache/maven-jmod-plugin
  1 "apache/maven-jdeps-plugin"
  1 apache/maven-indexer
  1 apache/maven-doxia
  1 apache/maven-doap-plugin
  1 "apache/maven-artifact-transfer"
  1 apache/maven-archetype

@elharo would this be something you're willing to review as well? Welcome to direct me to others too.

For my future self and others; Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu

@timtebeek
Copy link
Contributor Author

Thanks for the quick review @slachiewicz ; Would you be ok with me opening let's say six more starting from the top?

@slachiewicz
Copy link
Member

Yes, sure. Thx fro help

@timtebeek
Copy link
Contributor Author

Happy to help! I've opened a few more, all linked above, some of which need approval for the pipelines to run.
If it's alright with you I'll keep something in the range of five to ten open at a time, such that we get further along.

Open to other systems as well; there's a long tail of 1 or 2 cases per repository that might not make sense by itself.

timtebeek added a commit to timtebeek/maven-doxia-book-renderer that referenced this pull request Aug 20, 2023
timtebeek added a commit to timtebeek/maven-site-plugin that referenced this pull request Aug 20, 2023
timtebeek added a commit to timtebeek/maven-dependency-plugin that referenced this pull request Aug 20, 2023
timtebeek added a commit to timtebeek/maven-ejb-plugin that referenced this pull request Aug 20, 2023
timtebeek added a commit to timtebeek/maven-resolver that referenced this pull request Aug 20, 2023
timtebeek added a commit to timtebeek/maven-ejb-plugin that referenced this pull request Aug 20, 2023
timtebeek added a commit to timtebeek/maven-resolver that referenced this pull request Aug 20, 2023
elharo pushed a commit to apache/maven-resolver that referenced this pull request Aug 29, 2023
elharo pushed a commit to apache/maven-ejb-plugin that referenced this pull request Aug 29, 2023
elharo pushed a commit to apache/maven-site-plugin that referenced this pull request Aug 29, 2023
elharo pushed a commit to apache/maven-doxia-book-renderer that referenced this pull request Aug 29, 2023
slachiewicz pushed a commit to apache/maven-dependency-plugin that referenced this pull request Sep 13, 2023
michael-o pushed a commit to apache/maven-site-plugin that referenced this pull request Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants