[SUREFIRE-2146] Don't draw border around reporting tables (#596)

apache · Feb 9, 2023 · ee5e81e · ee5e81e
1 parent 11d0541
commit ee5e81e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/...lugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java b/...lugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
@@ -130,7 +130,7 @@ private void constructSummarySection( LocalizedProperties bundle, Sink sink )
 
         sink.table();
 
-        sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, true );
+        sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, false );
 
         sink.tableRow();
 
@@ -196,7 +196,7 @@ private void constructPackagesSection( LocalizedProperties bundle, Sink sink,
 
         sink.table();
 
-        sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, true );
+        sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, false );
 
         sink.tableRow();
 
@@ -281,7 +281,7 @@ private void constructPackagesSection( LocalizedProperties bundle, Sink sink,
             {
                 sink.table();
 
-                sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, true );
+                sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, false );
 
                 sink.tableRow();
 
@@ -412,7 +412,7 @@ private void constructTestCasesSection( LocalizedProperties bundle, Sink sink )
                 {
                     sink.table();
 
-                    sink.tableRows( new int[]{ LEFT, LEFT, LEFT }, true );
+                    sink.tableRows( new int[]{ LEFT, LEFT, LEFT }, false );
 
                     for ( ReportTestCase testCase : testCases )
                     {
@@ -555,7 +555,7 @@ private void constructFailureDetails( Sink sink, LocalizedProperties bundle, Lis
 
         sink.table();
 
-        sink.tableRows( new int[]{ LEFT, LEFT }, true );
+        sink.tableRows( new int[]{ LEFT, LEFT }, false );
 
         for ( ReportTestCase tCase : failures )
         {

diff --git a/...report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/Surefire597Test.java b/...report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/Surefire597Test.java
@@ -54,7 +54,7 @@ public void testCorruptedTestCaseFailureWithMissingErrorTypeAndMessage()
         gen.doGenerateReport( new SurefireReportMojo().getBundle( ENGLISH ), sink );
         String xml = writer.toString();
         assertThat( xml, containsString( toSystemNewLine(
-            "<table border=\"1\" class=\"bodyTable\">\n"
+            "<table border=\"0\" class=\"bodyTable\">\n"
                 + "<tr class=\"a\">\n"
                 + "<th>Tests</th>\n"
                 + "<th>Errors</th>\n"
@@ -72,7 +72,7 @@ public void testCorruptedTestCaseFailureWithMissingErrorTypeAndMessage()
                 + "</tr>"
                 + "</table>" ) ) );
         assertThat( xml, containsString( toSystemNewLine(
-            "<table border=\"1\" class=\"bodyTable\">\n"
+            "<table border=\"0\" class=\"bodyTable\">\n"
                 + "<tr class=\"a\">\n"
                 + "<th>Package</th>\n"
                 + "<th>Tests</th>\n"
@@ -90,7 +90,7 @@ public void testCorruptedTestCaseFailureWithMissingErrorTypeAndMessage()
                 + "<td align=\"left\">0%</td>\n"
                 + "<td align=\"left\">0</td></tr></table>" ) ) );
         assertThat( xml, containsString( toSystemNewLine(
-            "<table border=\"1\" class=\"bodyTable\">\n"
+            "<table border=\"0\" class=\"bodyTable\">\n"
                 + "<tr class=\"a\">\n"
                 + "<th></th>\n"
                 + "<th>Class</th>\n"
@@ -110,7 +110,7 @@ public void testCorruptedTestCaseFailureWithMissingErrorTypeAndMessage()
                 + "<td align=\"left\">0%</td>\n"
                 + "<td align=\"left\">0</td></tr></table>" ) ) );
         assertThat( xml, containsString( toSystemNewLine(
-            "<table border=\"1\" class=\"bodyTable\">\n"
+            "<table border=\"0\" class=\"bodyTable\">\n"
                 + "<tr class=\"a\">\n"
                 + "<td align=\"left\"><figure><img src=\"images/icon_error_sml.gif\" alt=\"\" /></figure></td>\n"
                 + "<td align=\"left\"><a id=\"surefire.MyTest.test\"></a>test</td></tr>\n"

diff --git a/surefire-api/src/test/java/org/apache/maven/surefire/api/testset/FundamentalFilterTest.java b/surefire-api/src/test/java/org/apache/maven/surefire/api/testset/FundamentalFilterTest.java
@@ -28,7 +28,7 @@
 /**
  * Inclusive test patters:<p>
  *
- * <table cellspacing=0 border=1>
+ * <table cellspacing=0 border=0>
  * <tr>
  * <td style=min-width:50px> test</td>
  * <td style=min-width:50px></td>
@@ -178,7 +178,7 @@
  * <p>
  * Exclusive test patters:<p>
  *
- * <table cellspacing=0 border=1>
+ * <table cellspacing=0 border=0>
  * <tr>
  * <td style=min-width:50px> test</td>
  * <td style=min-width:50px></td>