Change default debug options to not use legacy options

[Thihup]

Using the -Xdebug -Xnoagent -Djava.compiler=NONE causes the OpenJ9 JVM
to run the tests in interpreted mode, thus running them VERY slowly.
In Hotspot JVM these options are ignored.

[Tibor17]

Have you checked this change on Java 1.7 projects too?
We can always alter this feature upon Java version if necessary.

[Thihup]

I haven't tested it in Java 1.7 yet.
However, as far as I remember, these options were introduced in Java 1.5.

[Tibor17]

We have to make sure it is as you say, otherwise the Jenkins build would fail on old Java.
Here the GitHub workflow uses only Java 14 and 3 OS.

[Tibor17]

@Thihup
Do you think this change would not be in a conflict with JaCoCo AGENT?

[Thihup]

@Tibor17 I don't think so. Unfortunately, I don't have an extensive collection of projects with JaCoCo to test, but where I tested it worked fine.
The JaCoCo injects itself as a Java Agent and should not be affected by this change. The main option that can cause some fear is the Xnoagent.
However, in both JVM, the -Xnoagent does nothing, so I don't know where it could break:

Hotspot: https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/arguments.cpp#L2878
OpenJ9: https://github.com/eclipse/openj9/blob/master/runtime/vm/jvminit.c#L162

Do you have something in mind that we should try?

[Tibor17]

Yes, please check it out additionally with jacoco.

[rmannibucau]

Side note: for java 11, localhost:5005 is a saner default which works on java 8 (think 6 but didnt test), would be great to handle it too.

[Thihup]

@rmannibucau Sure. I didn't change to localhost:5005 because it changes the current behavior in JDK <= 8. I don't know if someone connects remotely during debug. If it OK to change I can change right away.

@Tibor17 I've tested and it looks fine

[Tibor17]

@Thihup thx

[rmannibucau]

@Thihup yep but 0.0.0.0:5005 is unsafe and not a good default anyway so guess it is better (if moving to current config as this issue is about) to fix that too properly. Worse case it is still configurable as before.

[Thihup]

@rmannibucau @Tibor17 I've changed to localhost:5005, however, some tests have failed and I couldn't understand why.
Can you have a look?

[Tibor17]

The GH workflows are really crappy. After the MSC has taken it, this CI is unreliable.
The jobs are duplicated, the uploads are skipped on Win and MacOS and I do not see the logs if any build fails.
I was working on it whole weekend and could not fix it.

[Thihup]

Is there something else I should do?

[Tibor17]

@Thihup
yes, we need to have updated documentation. Can you pls update it in debugging.apt.vm?
Pls check the other apt.vm files if there is important information for this task.
Produce only one commit altogether. And then rebase to the latest remote master.
Thx

[Thihup]

Done

[Tibor17]

What did you change 2 hours ago?

[Thihup]

I've just rebased to the latest remote

[Tibor17]

ok, i have created the Jira ticket SUREFIRE-1858.
So i will rename the commit to [SUREFIRE-1858] Change default debug options to not use legacy options and push it and close the ticket as well.

[Tibor17]

@Thihup Thx for contributing!