Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-JIRA] Refactor integration tests module #576

Merged

Conversation

SimonBaars
Copy link
Contributor

I recently picked up a task to remove the forkMode parameter (#575), and found parts of the code hard to work with because of redundant constructs in the code:

  • When a method has throws Exception, I expect the method to throw the wildest things if we have to use the base Exception class in the method declaration. Oftentimes, there were no checked exceptions at all. I removed the declarations where they were not needed and refactored some others where Exception was too much to be thrown.
  • There was some commented code dating back many years ago, which is unlikely to be used again. Better to remove it and reduce cognitive load.
  • Some methods were unused.
  • A few other small issues

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slawekjaranowski
Copy link
Member

@SimonBaars can you resolve conflicts?

@SimonBaars
Copy link
Contributor Author

@SimonBaars can you resolve conflicts?

On it!

@SimonBaars SimonBaars force-pushed the NO-JIRA-refactor-integration-tests branch from 75772c1 to 44e6735 Compare December 23, 2022 09:20
@slawekjaranowski slawekjaranowski merged commit 7815927 into apache:master Dec 23, 2022
@slawekjaranowski
Copy link
Member

@SimonBaars thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants