Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2136] Rename test dir that contains colon #585

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

andpab
Copy link
Contributor

@andpab andpab commented Dec 19, 2022

In the UmlautDirIT two special directories are created that have a colon character in the name. This causes problems with the artifact upload of the Github actions, so we rename those directories at the end of the test to something without a colon character in it.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@andpab andpab force-pushed the SUREFIRE-2136 branch 2 times, most recently from b7d667a to f29615a Compare December 19, 2022 09:44
In the UmlautDirIT two special directories are created that have a
colon character in the name. This causes problems with the artifact
upload of the Github actions, so we rename those directories in a
finally block at the end of the test to something without a colon
character in it.
@slawekjaranowski slawekjaranowski self-assigned this Dec 19, 2022
@slawekjaranowski slawekjaranowski merged commit ce16679 into apache:master Dec 19, 2022
@andpab andpab deleted the SUREFIRE-2136 branch December 19, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants