Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-7751] Provide a way to inject XmlNode into plugins #1071

Merged
merged 1 commit into from
Jun 12, 2023
Merged

[MNG-7751] Provide a way to inject XmlNode into plugins #1071

merged 1 commit into from
Jun 12, 2023

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Mar 24, 2023 •
edited
Loading

JIRA issue MNG-7751

This PR provides the ability to inject an XmlNode object into a plugin. This can be currently done by injecting a PlexusConfiguration, but injecting an XmlNode ensures there's no dependency on the internal plexus configuration bits and limits the plugin exposure to the maven v4 api.

slachiewicz
slachiewicz reviewed Mar 24, 2023
View reviewed changes
Copy link
Member

@slachiewicz slachiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we similar way incject Path?

@gnodet
Copy link
Contributor Author

gnodet commented Mar 29, 2023 •
edited
Loading

Can we similar way incject Path?

Yes, that's already possible, see
https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/configuration/internal/DefaultBeanConfigurator.java#L136-L164
and
https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/configuration/internal/EnhancedConverterLookup.java#L31

@gnodet gnodet changed the title Provide a way to inject XmlNode into plugins [MNG-7751] Provide a way to inject XmlNode into plugins Mar 29, 2023
@gnodet gnodet added this to the 4.0.0-alpha-6 milestone May 16, 2023
@gnodet gnodet merged commit 56ee6a8 into apache:master Jun 12, 2023
@gnodet gnodet deleted the xml-converter branch November 18, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slachiewicz slachiewicz slachiewicz left review comments

@rmannibucau rmannibucau rmannibucau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0-alpha-7
Development

Successfully merging this pull request may close these issues.
3 participants
@gnodet @rmannibucau @slachiewicz