Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8225] Fully concurrent builder for Maven 4 #1429

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Feb 27, 2024

JIRA issue: MNG-8225

This PR aims at defining a complete new lifecycle for Maven 4. This lifecycle is disabled by default and needs to be turned on using mvn --builder=concurrent.

Note that the builder is fully concurrent, so that a project may not be executed in a single thread and continuously, rather, all mojos will be scheduled independently. The builder displays a nice summary at the beginning (currently at info level).

Status

To avoid MNG-7335, MNG-6843 and all those long standing related bugs, the new lifecycle/builder warns when using non Maven 4 mojos (kinda like we have with the multithreaded builder which warns when mojos are not flagged as thread safe).

@gnodet gnodet force-pushed the concurrent-lifecycle branch 2 times, most recently from c96755e to 02cdc33 Compare February 29, 2024 07:01
@gnodet gnodet changed the title Concurrent lifecycle for Maven 4 Fully concurrent builder for Maven 4 Mar 13, 2024
@gnodet gnodet force-pushed the concurrent-lifecycle branch 3 times, most recently from 8de48d9 to 48fde02 Compare July 11, 2024 10:03
@gnodet gnodet marked this pull request as ready for review July 11, 2024 10:04
@gnodet gnodet changed the title Fully concurrent builder for Maven 4 [MNG-8052] Fully concurrent builder for Maven 4 Jul 11, 2024
@gnodet gnodet requested a review from cstamas July 11, 2024 10:11
@gnodet gnodet added this to the 4.0.0-beta-4 milestone Jul 11, 2024
@cstamas
Copy link
Member

cstamas commented Jul 11, 2024

Can you point me where "concurrent" is enabled by def? I cannot find that spot

@gnodet
Copy link
Contributor Author

gnodet commented Jul 12, 2024

Can you point me where "concurrent" is enabled by def? I cannot find that spot

It was enabled in earlier versions, I disabled it a few days ago.

@gnodet gnodet changed the title [MNG-8052] Fully concurrent builder for Maven 4 [MNG-8225] Fully concurrent builder for Maven 4 Aug 28, 2024
@gnodet gnodet merged commit e11b475 into apache:master Aug 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants