Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8228] Enable Sisu Plexus strict classpath scanning #1688

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

kwin
Copy link
Member

@kwin kwin commented Aug 29, 2024

This was introduced with
eclipse-sisu/sisu.plexus#51.

This leads to exceptions in case of issues with loading potential extensions/plexus components instead of logging just with DEBUG level.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

This was introduced with
eclipse-sisu/sisu.plexus#51.

This leads to exceptions in case of issues with loading potential
extensions/plexus components instead of logging just with DEBUG level.
@kwin kwin requested review from cstamas and gnodet August 29, 2024 13:49
@gnodet gnodet added this to the 4.0.0-beta-4 milestone Aug 29, 2024
@gnodet gnodet merged commit 3f430bb into master Aug 29, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants