Repair Jenkins job - add a full path to workspace when run on Windows #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes errors like: Cannot relativize 'c:\mvn-it-0.tmp\core-it-support\..' relatively to '/mvn-it-0.tmp' Reference JENKINS-52657
olamy
requested changes
Oct 1, 2018
| @@ -79,7 +79,7 @@ for (String os in runITsOses) { | |||
| // on Windows, need a short path or we hit 256 character limit for paths | |||
| // using EXECUTOR_NUMBER guarantees that concurrent builds on same agent | |||
| // will not trample each other | |||
| dir(isUnix() ? 'test' : "/mvn-it-${EXECUTOR_NUMBER}.tmp") { | |||
| dir(isUnix() ? 'test' : "c:\\mvn-it-${EXECUTOR_NUMBER}.tmp") { | |||
There was a problem hiding this comment.
I'm not a windows expert but c: seems to be hardcoded and can cause some issues?
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Nov 20, 2024
* Modernize IT plugins to use annotations * Align some tests to maven 3.8.6 # Conflicts: # core-it-suite/src/test/resources-filtered/bootstrap.txt # core-it-suite/src/test/resources/mng-3221/report/pom.xml # core-it-suite/src/test/resources/mng-3428/pom.xml # core-it-suite/src/test/resources/mng-3530/build-path/plugin/pom.xml # core-it-suite/src/test/resources/mng-3530/pom-property/plugin/pom.xml # core-it-suite/src/test/resources/mng-3530/resource-object/plugin/pom.xml # core-it-suite/src/test/resources/mng-3704/maven-mng3704-plugin/pom.xml # core-it-suite/src/test/resources/mng-3743/plugins/maven-mng3743-check-plugin/pom.xml # core-it-suite/src/test/resources/mng-3743/plugins/maven-mng3743-report-plugin/pom.xml # core-it-suite/src/test/resources/mng-3743/project/pom.xml # core-it-suite/src/test/resources/mng-4086/repo/org/apache/maven/its/mng4086/maven-it-plugin-a/0.1/maven-it-plugin-a-0.1.pom # core-it-suite/src/test/resources/mng-4086/repo/org/apache/maven/its/mng4086/maven-it-plugin-a/0.2-SNAPSHOT/maven-it-plugin-a-0.2-20090315.124508-1.pom # core-it-suite/src/test/resources/mng-5581-lifecycle-mapping-delegate/extension/pom.xml # core-it-suite/src/test/resources/mng-7310-lifecycle-activated-in-specified-module/project/pom.xml * Add dependencies on all support artifacts to ensure multithreaded builds can use correct ordering * Add missing dependencies on plexus-utils * Fix for mng-7335 test * Fix ITs for maven 4 * Rename Component -> TestComponent to leave room for the annotation * Upgrade a few plugin versions * Upgrade some JDK requirements to 1.8 * Remove unwanted parentheseses * Convert the last mojo to annotations * Force timestamped build * Fix ITs following Component -> TestComponent rename * Remove commented block * Remove versions infered from plugin management * The implementation parameter is not supported anymore * Align maven core version * Fix bad merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors like: Cannot relativize 'c:\mvn-it-0.tmp\core-it-support..' relatively to '/mvn-it-0.tmp'
Reference JENKINS-52657