MNG-5577: convert remaining non core/compat modules #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch (most) @components in maven-model-builder to javax.inject's annotations. Leave DefaultModelBuilder and DefaultProfileSelector as-is due to their use of optional injection and injecting collections.
Make the tests in maven-model-builder work with non-Plexus components. - Construct directly, rather than via Plexus, where it's simpler - Enable classpath scanning in tests so that the JSR330 annotations are picked up.
This test is already commented out; @ignore it as well, rather than making changes.
- Remove more use of PlexusTestCase - Mark DefaultModelReader so it's preferred over DefaultModelProcessor, to prevent circular wiring. - Require classpath scanning when testing injection of ProfileActivators
With unit tests passing to confirm that @Inject behaves with Lists, convert this class.
josephw
force-pushed
the
MNG-5577-convert-remaining-non-core-modules
branch
from
9940d04 to
4217373
Compare
Sisu understands that @nullable things are optional. Use that to convert the remaining class in maven-model-builder.
|
I would really prefer to have seperate tickets and PRs for each module. I don't want to review and merge so many changes at once. |
|
Thank you for your hard work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further conversion to JSR 330 annotations, following Plexus Migration -- everything outside core and compat, with some test changes to adjust.
This incorporates #232 by @slachiewicz, but omits the logging change in 39ca59d to focus on the annotations.
In tests, use of
PlexusTestCasefor trivial wiring is reduced, to directly construct the classes under test. Tests that do more significant wiring are modified to usePlexusConstants.SCANNING_ONso JSR 330-annotated classes no longer included in component indexes are picked up.Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MNG-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.